From 812c109e8790aa50388fae98b5c084d39dcfba30 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Thu, 5 Mar 2026 12:44:52 -0500 Subject: [PATCH] Remove `message` argument from `NoteLengthValidator` error approach (#37977) --- app/validators/note_length_validator.rb | 2 +- spec/requests/api/v1/accounts/credentials_spec.rb | 2 +- spec/requests/api/v1/profiles_spec.rb | 2 +- spec/validators/note_length_validator_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/validators/note_length_validator.rb b/app/validators/note_length_validator.rb index 1a16bbf2b3..9e554e49c0 100644 --- a/app/validators/note_length_validator.rb +++ b/app/validators/note_length_validator.rb @@ -2,7 +2,7 @@ class NoteLengthValidator < ActiveModel::EachValidator def validate_each(record, attribute, value) - record.errors.add(attribute, :too_long, message: I18n.t('statuses.over_character_limit', max: options[:maximum]), count: options[:maximum]) if too_long?(value) + record.errors.add(attribute, :too_long, count: options[:maximum]) if too_long?(value) end private diff --git a/spec/requests/api/v1/accounts/credentials_spec.rb b/spec/requests/api/v1/accounts/credentials_spec.rb index f68ebbdb22..a3cbc40e0f 100644 --- a/spec/requests/api/v1/accounts/credentials_spec.rb +++ b/spec/requests/api/v1/accounts/credentials_spec.rb @@ -91,7 +91,7 @@ RSpec.describe 'credentials API' do expect(response.parsed_body) .to include( error: /Validation failed/, - details: include(note: contain_exactly(include(error: 'ERR_TOO_LONG', description: /character limit/))) + details: include(note: contain_exactly(include(error: 'ERR_TOO_LONG', description: /too long/))) ) end end diff --git a/spec/requests/api/v1/profiles_spec.rb b/spec/requests/api/v1/profiles_spec.rb index faff16bcc1..b2c74b0191 100644 --- a/spec/requests/api/v1/profiles_spec.rb +++ b/spec/requests/api/v1/profiles_spec.rb @@ -89,7 +89,7 @@ RSpec.describe 'Profile API' do expect(response.parsed_body) .to include( error: /Validation failed/, - details: include(note: contain_exactly(include(error: 'ERR_TOO_LONG', description: /character limit/))) + details: include(note: contain_exactly(include(error: 'ERR_TOO_LONG', description: /too long/))) ) end end diff --git a/spec/validators/note_length_validator_spec.rb b/spec/validators/note_length_validator_spec.rb index b391390a55..1acf33575b 100644 --- a/spec/validators/note_length_validator_spec.rb +++ b/spec/validators/note_length_validator_spec.rb @@ -50,7 +50,7 @@ RSpec.describe NoteLengthValidator do private def too_long_message - I18n.t('statuses.over_character_limit', max: 100) + I18n.t('errors.messages.too_long', count: 100) end def starting_string