Leatherface/mastodon
0
0
Fork 0
mirror of https://github.com/glitch-soc/mastodon.git synced 2026-03-29 03:00:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update doorkeeper i18n for invalid code challenge method (#37827)

Browse Source
This commit is contained in:
Matt Jankowski
2026-02-17 04:01:59 -05:00
committed by GitHub
parent 1618c28a48
commit 2cb8471d81
2 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
spec/system/oauth_spec.rb
View File

@@ -98,28 +98,27 @@ RSpec.describe 'Using OAuth from an external app' do
context 'when using plain code challenge method' do
let(:pkce_code_challenge_method) { 'plain' }
it 'does not include the PKCE values in the response' do
it 'shows an error message and does not include the PKCE values or authorize button' do
subject
expect(page).to have_no_css('.oauth-prompt input[name=code_challenge]')
expect(page).to have_no_css('.oauth-prompt input[name=code_challenge_method]')
end
it 'does not include the authorize button' do
subject
expect(page).to have_no_css('.oauth-prompt button[type="submit"]')
end
it 'includes an error message' do
subject
expect(page)
.to have_no_css('.oauth-prompt input[name=code_challenge]')
.and have_no_css('.oauth-prompt input[name=code_challenge_method]')
.and have_no_css('.oauth-prompt button[type="submit"]')
within '.form-container .flash-message' do
# FIXME: Replace with doorkeeper.errors.messages.invalid_code_challenge_method.one for Doorkeeper > 5.8.0
# see: https://github.com/doorkeeper-gem/doorkeeper/pull/1747
expect(page).to have_content(I18n.t('doorkeeper.errors.messages.invalid_code_challenge_method'))
expect(page)
.to have_content(doorkeeper_invalid_code_message)
end
end
def doorkeeper_invalid_code_message
I18n.t(
'doorkeeper.errors.messages.invalid_code_challenge_method',
challenge_methods: Doorkeeper.configuration.pkce_code_challenge_methods.join(', '),
count: Doorkeeper.configuration.pkce_code_challenge_methods.length
)
end
end
context 'when the user has yet to enable TOTP' do